[PRMP-1083] Clean up Lambda Errors and Exceptions #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
NogaNHS
previously approved these changes
Jan 5, 2026
steph-torres-nhs
had a problem deploying
to
development
GitHub Actions
Failure
steph-torres-nhs
had a problem deploying
to
development
GitHub Actions
Failure
lambdas/enums/lambda_error.py
Outdated
| } | ||
|
|
||
| DocumentReviewDB = { | ||
| "err_code": "UDR_5001", |
Contributor
There was a problem hiding this comment.
I think we created UDR error code for update document reference errors, should you use DRV here ( if it stands for document review) ? and on line 540
lambdas/enums/lambda_error.py
Outdated
Comment on lines
514
to
518
| UpdateDocStatusUnavailable = { | ||
| "err_code": "DRV_4003", | ||
| "err_code": "UDR_4001", | ||
| "message": "This Document is not available for review update", | ||
| "fhir_coding": FhirIssueCoding.FORBIDDEN, | ||
| } |
Contributor
There was a problem hiding this comment.
can this be DocumentReviewStatusUnavailable?
or something that starts with DocumentReview, so it is consistent with the other errors in this group?
lambdas/enums/lambda_error.py
Outdated
Comment on lines
549
to
552
| SearchDocumentInvalidQuerystring = { | ||
| "err_code": "SDR_4002", | ||
| "message": "Invalid query string passed", | ||
| } |
Contributor
There was a problem hiding this comment.
SearchDocumentInvalidQueryString I suppose
steph-torres-nhs
had a problem deploying
to
development
GitHub Actions
Failure
Code security issues foundView full details here. |
kamenbachvarov-nhs
approved these changes
Jan 13, 2026
|
NogaNHS
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: PRMP-1083
Description
As a Developer, I want to replace duplicated and overly specific exception classes with a set of generic, reusable errors So that the codebase is easier to maintain, the API responses are consistent, and we reduce unnecessary boilerplate code.
Context
Review Feature tidy up
Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)[ ] 4. I have updated relevant documentation.Deploy - Sandbox- workflow runSANDBOX Full- Deploy feature branch to sandbox- workflow run